-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating documentation on 0.27-maintenance to respect ctest #2033
Conversation
…ate changes from main/README.md in this PR.
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #2033 +/- ##
====================================================
- Coverage 58.74% 58.72% -0.03%
====================================================
Files 146 146
Lines 23004 23004
Branches 12596 12596
====================================================
- Hits 13513 13508 -5
- Misses 6689 6693 +4
- Partials 2802 2803 +1
Continue to review full report at Codecov.
|
@kmilos. I'm getting 100% test failure with the Visual Studio build. I have to provide You mentioned something about 'git config'. Is that something I need to deal with? Any ideas what might be the matter? I'm sure it's related to line-endings. |
No, that was very Cygwin specific. I can take a look, but might be a while, the dad hat rarely comes off during the weekend... |
@clanmills The Windows CI seems to be ok? I see only codecov failing (no idea why).... |
Keep the Dad hat on. The CI is happy. I installed cmake 3.22, pulled down fresh code and built. Looks good.
Grampa is talking shit as always. |
Codecov is a "bloody old woman!". It's complaining because code coverage has gone down (by almost nothing). We'll ignore that. I'm sure I'll add more polish/fixes to this PR over the weekend. |
… It's not possible to add lensTest into 0.27-maintenance without modifying Exiv2::getExiv2ConfigPath().
This PR has been sitting in MSYS2 doing "setup" for 5 hours, so I cancelled it. Everything else passed and this PR cannot be involved in setting up the build machine. I looked at the documentation concerning codecov. I think we can set threshold in codecov.yml to ignore negative code coverage. The codecov documentation needs more careful investigation to decide what should be done. I'm going to merge. |
Yeah, I've seen GHA jobs get stuck before on occasion... |
Initial changes to documentation to support CTest. I intend to integrate changes from main/README.md in this PR.